Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flaky TestForStateRestore test #4476

Closed
simonpasquier opened this Issue Aug 7, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@simonpasquier
Copy link
Member

simonpasquier commented Aug 7, 2018

make test has failed on my local machine with:

--- FAIL: TestForStateRestore (0.02s)
        testing.go:68: 
                exp: labels.Labels{labels.Label{Name:"alertname", Value:"HTTPRequestRateLow"}, labels.Label{Name:"group", Value:"canary"}, labels.Label{Name:"instance", Value:"1"}, labels.Label{Name:"job", Value:"app-server"}, labels.Label{Name:"severity", Value:"critical"}}

                got: labels.Labels{labels.Label{Name:"alertname", Value:"HTTPRequestRateLow"}, labels.Label{Name:"group", Value:"canary"}, labels.Label{Name:"instance", Value:"0"}, labels.Label{Name:"job", Value:"app-server"}, labels.Label{Name:"severity", Value:"critical"}}
FAIL
FAIL    github.com/prometheus/prometheus/rules  0.156s
@gouthamve

This comment has been minimized.

Copy link
Member

gouthamve commented Aug 16, 2018

/cc @codesome

Though tbh, I see exp and got to be the same thing according the log above :)

@codesome

This comment has been minimized.

Copy link
Member

codesome commented Aug 16, 2018

I think I found what is the bug: The alerts in got and exp should be sorted w.r.t the Labels before comparing, which is not being done right now. I will open a PR on this.

codesome added a commit to codesome/prometheus that referenced this issue Aug 16, 2018

Fix TestForStateRestore (prometheus#4476)
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>

gouthamve added a commit that referenced this issue Aug 16, 2018

Fix TestForStateRestore (#4476) (#4512)
Signed-off-by: Ganesh Vernekar <cs15btech11018@iith.ac.in>
@lock

This comment has been minimized.

Copy link

lock bot commented Mar 22, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.