Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd hidden labels for outgoing alerts #4490
Comments
This comment has been minimized.
This comment has been minimized.
|
The challenge will be that that __for duration: should it part of the fingerprint of the labelset of the alert? |
This comment has been minimized.
This comment has been minimized.
|
Why do you want this? If you want to specify a label, you can add it explicitly in your alerting rule. |
This comment has been minimized.
This comment has been minimized.
|
some of our notifiers are graphing the alerts and other promql that we pass as annotations; but getting the "for" information once for all the alerts would be a nice shortcut versus needed to ensure that he "for" label is aligned with the "for" duration of the alert. I propose a hidden label by default so that people who have no interest in that are not affected. |
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
|
In alerting terms, we already have annotations for the role of non-identifying labels. I don't think this is something that we should be sending by default as it'd pollute the default notifications and others that list all annotations - and thus is also a breaking change. I think this is better served by being handled in configuration management. |
This comment has been minimized.
This comment has been minimized.
|
ack |
roidelapluie
closed this
Aug 13, 2018
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 22, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
roidelapluie commentedAug 12, 2018
As part of the alerts metrics relabelling,
I would like to have access to a hidden field
__for
which would be the "for" clause of the alert.
Then I can do: