bug in SD k8s missing wg.Wait.

[krasi-georgiev]

prometheus/discovery/kubernetes/kubernetes.go

Lines 363 to 370 in 0b4d22b

	var wg sync.WaitGroup
	for _, dd := range d.discoverers {
	wg.Add(1)
	go func(d discoverer) {
	defer wg.Done()
	d.Run(ctx, ch)
	}(dd)
	}

this is missing wg.Wait so looks like a bug.

ping @cofyc

[cofyc]

sorry, my mistake, ctx.Done() notifies all goroutines to exit, but it's better to wait all goroutines are done before exiting from Discovery.Run. Created a fix PR: #4508

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.