Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notify user if configuration contains duplicated scrape targets #451

Closed
grobie opened this Issue Jan 16, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@grobie
Copy link
Member

grobie commented Jan 16, 2015

Given a configuration which contains the same target under several job names, there should be some kind of feedback to the user.

Example:

"jobs" => [
  {
    "name": "foo",
    "address": "qux.address.example"
  },
  {
    "name": "bar",
    "address": "qux.address.example"
  }
]

Idea:
As a simple idea, we could add a warning banner (e.g. bootstrap) to the top of all prometheus server pages in that case. Alternatively such a config could be simply rejected on bootstrap, pending whether there are valid use cases for the quoted config.

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Jan 16, 2015

This is a valid configuration, for example a server might have multiple roles that require different labels or different scrape parameters.

@fabxc

This comment has been minimized.

Copy link
Member

fabxc commented May 13, 2015

Closable?

@grobie grobie closed this May 15, 2015

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.