Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upDistinguish not-yet-evaluated alert from empty alert #4510
Comments
brian-brazil
added
component/ui
component/rules
priority/P3
labels
Aug 16, 2018
This comment has been minimized.
This comment has been minimized.
|
Hmm, what happens if there's two alerting rules with the same name? |
roidelapluie
changed the title
Distinguish not+yet-evaluated alert from empty alert
Distinguish not-yet-evaluated alert from empty alert
Aug 20, 2018
gouthamve
added
help wanted
low hanging fruit
labels
Aug 21, 2018
This comment has been minimized.
This comment has been minimized.
|
This should be easy to fix as there is already a Health() that will return HealthUknown if the rule is not yet evaluated. |
This comment has been minimized.
This comment has been minimized.
|
@brian-brazil valid concern; no matter how many alerting rules share the name there are always a sum of n active alerts plus m alert defintions with unknown state.
|
This comment has been minimized.
This comment has been minimized.
|
Mentioning |
This comment has been minimized.
This comment has been minimized.
|
No need for approval, go ahead :)
Sent by mobile; please excuse my brevity.
…On Fri, Aug 24, 2018, 16:19 Harsh Agarwal ***@***.***> wrote:
Mentioning (n active and m alerting rules unknown) sounds like a good
idea.
If there is an approval, I can open PR for this
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#4510 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAuEI-C9eor5r-vqTHledls-K5dSvr1Uks5uUAtWgaJpZM4V_eqL>
.
|
sipian
referenced a pull request that will
close
this issue
Aug 29, 2018
Open
Add UNKNOWN alert state in alerts page #4559
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
roidelapluie commentedAug 16, 2018
Like we do for targets (UNKNOWN) I'd like to see alerts that have mnot yet been evaluated (after a restart or new alerts) marked as unknown.