Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish not-yet-evaluated alert from empty alert #4510

Open
roidelapluie opened this Issue Aug 16, 2018 · 5 comments

Comments

Projects
None yet
5 participants
@roidelapluie
Copy link
Contributor

roidelapluie commented Aug 16, 2018

Like we do for targets (UNKNOWN) I'd like to see alerts that have mnot yet been evaluated (after a restart or new alerts) marked as unknown.

ne

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Aug 16, 2018

Hmm, what happens if there's two alerting rules with the same name?

@roidelapluie roidelapluie changed the title Distinguish not+yet-evaluated alert from empty alert Distinguish not-yet-evaluated alert from empty alert Aug 20, 2018

@gouthamve

This comment has been minimized.

Copy link
Member

gouthamve commented Aug 21, 2018

This should be easy to fix as there is already a Health() that will return HealthUknown if the rule is not yet evaluated.

@RichiH

This comment has been minimized.

Copy link
Member

RichiH commented Aug 21, 2018

@brian-brazil valid concern; no matter how many alerting rules share the name there are always a sum of n active alerts plus m alert defintions with unknown state.

(n active and m alerting rules unknown) sounds a bit kludgy, but it would fit the intention exactly.

@sipian

This comment has been minimized.

Copy link
Contributor

sipian commented Aug 24, 2018

Mentioning (n active and m alerting rules unknown) sounds like a good idea.
If there is an approval, I can open PR for this

@RichiH

This comment has been minimized.

Copy link
Member

RichiH commented Aug 24, 2018

@sipian sipian referenced a pull request that will close this issue Aug 29, 2018

Open

Add UNKNOWN alert state in alerts page #4559

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.