Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upMake the Discovery throtling configurable to allow easier testing. #4565
Comments
krasi-georgiev
referenced this issue
Sep 4, 2018
Merged
tidy up the discovery logs,updating loops and selects #4556
simonpasquier
changed the title
Make the Discovery throtling configurable to allow easyer testing.
Make the Discovery throtling configurable to allow easier testing.
Sep 5, 2018
This comment has been minimized.
This comment has been minimized.
|
I'm going to try to fix this. |
janickic
referenced this issue
Sep 6, 2018
Closed
Add updaterTicker that can be overwritten in tests. #4581
simonpasquier
closed this
in
#4582
Sep 27, 2018
lock
bot
locked and limited conversation to collaborators
Mar 26, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
krasi-georgiev commentedAug 30, 2018
prometheus/discovery/manager.go
Line 134 in 75bd348
Sending the discovery updates are hard coded to throttle at 5 seconds.
This makes creaating test for these parts of the code needing to wait 5 seconds so not good for unit testing. We need to make this somehow configurable so that we can adjust when creating unit tests.
With this change to the same PR can also add a test for: