Skip to content

/prometheus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`count_values` doesn't validate the provided label name #4584

Closed
beorn7 opened this Issue Sep 6, 2018 · 1 comment

Comments

Assignees
No one assigned
Labels
component/promql help wanted kind/bug low hanging fruit
Projects
None yet
Milestone
No milestone
2 participants
@beorn7 @brian-brazil
@beorn7
Copy link
Member

beorn7 commented Sep 6, 2018

Bug Report

What did you do?

Evaluated the following expression in the expression browser:

count_values("is it up?", up)

What did you expect to see?

Error: Invalid label name "is it up?".

What did you see instead? Under which circumstances?

{is it up?="1"} | 639
{is it up?="0"} | 8

In short, count_values accepts label values that are not valid.

@beorn7 beorn7 added kind/bug component/promql labels Sep 6, 2018

@brian-brazil brian-brazil added help wanted low hanging fruit labels Sep 6, 2018

@codesome codesome referenced this issue Sep 7, 2018

Merged

Label name check for 'count_values' #4585

@gouthamve gouthamve closed this in #4585 Sep 13, 2018

@lock

This comment has been minimized.

Sign in to view
Copy link

lock bot commented Mar 22, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.