Skip to content

/prometheus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backward vs forward compatibility #4597

Closed
AlekSi opened this Issue Sep 12, 2018 · 3 comments

Comments

Assignees
No one assigned
Labels
component/documentation
Projects
None yet
Milestone
No milestone
3 participants
@AlekSi @gouthamve @simonpasquier
@AlekSi
Copy link
Contributor

AlekSi commented Sep 12, 2018

CHANGELOG.md currently says:

Further, the WAL implementation has been re-written so the storage is not backward compatible. Prometheus 2.3 storage will work on 2.4 but not vice-versa.

The first sentence there contradicts the second one. Wikipedia explains Backward compatibility as

A data format is said to be backward compatible with its predecessor if every message or file that is valid under the old format is still valid, retaining its meaning under the new format.

So storage is backward compatible.

@simonpasquier simonpasquier added the component/documentation label Sep 12, 2018

@gouthamve

This comment has been minimized.

Sign in to view
Copy link
Member

gouthamve commented Sep 12, 2018

Ooops, will fix. I updated the releases page, now will open a PR to the changelog.

@gouthamve gouthamve referenced this issue Sep 12, 2018

Merged

changelog: /s/backward compatible/forward compatible/ #4600

gouthamve added a commit to gouthamve/prometheus that referenced this issue Sep 12, 2018

@gouthamve
changelog: /s/backward compatible/forward compatible/ 
Fixes prometheus#4597

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Verified
This commit was signed with a verified signature.
@gouthamve gouthamve Goutham Veeramachaneni
GPG key ID: F1C217E8E9023CAD Learn about signing commits
32fe1d4

gouthamve added a commit that referenced this issue Sep 12, 2018

@gouthamve
changelog: /s/backward compatible/forward compatible/ (#4600) 
Fixes #4597

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
16532a7
@gouthamve

This comment has been minimized.

Sign in to view
Copy link
Member

gouthamve commented Sep 14, 2018

Closed in #4600

@gouthamve gouthamve closed this Sep 14, 2018

bobmshannon pushed a commit to bobmshannon/prometheus that referenced this issue Nov 19, 2018

Bob Shannon GitHub Enterprise
Upgrade Prometheus to 2.4.2 (prometheus#27) 
* changelog: /s/backward compatible/forward compatible/ (prometheus#4600)

Fixes prometheus#4597

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>

* web: fix asset paths for Windows platforms (prometheus#4616)

* web: fix asset paths for Windows platforms

Signed-off-by: Simon Pasquier <spasquie@redhat.com>

* web: add tests

Signed-off-by: Simon Pasquier <spasquie@redhat.com>

* vendor: update prometheus/tsdb (prometheus#4631)

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>

* release 2.4.1 (prometheus#4632)

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>

* release 2.4.2 (prometheus#4636)

* vendor: Update prometheus/tsdb

This time, properly

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>

* release 2.4.2

Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
50fbd9a
@lock

This comment has been minimized.

Sign in to view
Copy link

lock bot commented Mar 22, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 22, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.