Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Proposal] Allow UTF8 string to be metric and label name #4615

Closed
viciss opened this Issue Sep 17, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@viciss
Copy link

viciss commented Sep 17, 2018

Proposal

For now, the metric and label name meets the regex expression [a-zA-Z_:][a-zA-Z0-9_:]*,
but sometimes it is not enough for some cases, like:

  • 5xx_http_response to indicate a metric for all http response with 5xx error,
  • Some non ASCII letters to be a metric name will be more meaningful for localization

So, would it be possible to extend the metric and label name to support UTF8 string?
Thanks!

@GiedriusS

This comment has been minimized.

Copy link
Contributor

GiedriusS commented Oct 4, 2018

But where would we draw the line? Some symbols are obviously reserved e.g. { or }. For the first case I suggest adding the response code to the labels. The second one is a legit issue but IMHO I do not think that this should be done at the metrics level. Perhaps something on the top should translate the HELP strings.

@simonpasquier

This comment has been minimized.

Copy link
Member

simonpasquier commented Oct 4, 2018

I'm closing this request as in the near future, Prometheus aims at being compliant with OpenMetrics which will be the source of truth for the exposition format.

@lock lock bot locked and limited conversation to collaborators Apr 2, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.