Skip to content

/prometheus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run tests on Windows #4622

Open
gouthamve opened this Issue Sep 17, 2018 · 1 comment

Comments

Assignees
No one assigned
Labels
component/tests
Projects
None yet
Milestone
No milestone
2 participants
@gouthamve @simonpasquier
@gouthamve
Copy link
Member

gouthamve commented Sep 17, 2018

So, we had windows break a bunch of times before and while we could add tests to check that, we never really run the tests on Windows. Like this test proposed here: #4616 (comment) would never catch itself breaking because Travis and Circle run on Linux and while the test breaks on windows.

@simonpasquier simonpasquier added the component/tests label Sep 17, 2018

@simonpasquier

This comment has been minimized.

Sign in to view
Copy link
Member

simonpasquier commented Sep 17, 2018

At the minimum, we need to check that the current tests are passing on Windows and fix them if not.

@gouthamve gouthamve referenced this issue Sep 19, 2018

Merged

Fix filehandling for windows #392

@simonpasquier simonpasquier referenced this issue Sep 28, 2018

Open

Tests don't pass on Windows #1561

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.