Skip to content

/prometheus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All errors come back as internal errors from api.query() #4629

Closed
bboreham opened this Issue Sep 18, 2018 · 2 comments

Comments

Assignees
No one assigned
Labels
component/promql kind/bug
Projects
None yet
Milestone
No milestone
3 participants
@bboreham @krasi-georgiev @simonpasquier
@bboreham
Copy link
Contributor

bboreham commented Sep 18, 2018 •
edited

This type assertion matches ErrorStorage for all types of error, because ErrorStorage is an alias to the error interface.

https://golang.org/ref/spec#Type_assertions

I believe this is the cause of cortexproject/cortex#780, though I actually found it while chasing something else.

@bboreham bboreham referenced this issue Sep 18, 2018

Merged

Make ErrStorage a concrete type not an interface #4628

@bboreham

This comment has been minimized.

Sign in to view
Copy link
Contributor Author

bboreham commented Sep 18, 2018

While I'm here, why does query make a storage error into an internal error while queryRange does not?

@simonpasquier simonpasquier added component/local storage kind/bug labels Sep 21, 2018

@krasi-georgiev krasi-georgiev added component/promql and removed component/local storage labels Oct 1, 2018

@krasi-georgiev

This comment has been minimized.

Sign in to view
Copy link
Member

krasi-georgiev commented Oct 1, 2018

@simonpasquier I think this is related to the promql so updated the labels.

@gouthamve gouthamve closed this in #4628 Nov 14, 2018

@gouthamve gouthamve referenced this issue Nov 14, 2018

Merged

web(api): Make query and range api errors match #4866

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.