Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metric for number of remote_read queries in-flight #4661

Closed
gouthamve opened this Issue Sep 26, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@gouthamve
Copy link
Member

gouthamve commented Sep 26, 2018

We have a metric that shows the number in-flight queries on the promql engine: prometheus_engine_queries, with the introduction of the concurrency limits #4656, a similar metric should be added for in-flight remote-read queries.

@tariq1890

This comment has been minimized.

Copy link
Contributor

tariq1890 commented Sep 29, 2018

I can take this up

@tariq1890

This comment has been minimized.

Copy link
Contributor

tariq1890 commented Oct 2, 2018

Hi @gouthamve . To continue the discussion, I had created the other PR based on how other metrics were tracked in the prometheus codebase.

If I understand correctly, We want a remote read metric at the api module level regardless of the underlying remote storage implementation used. Please correct me If I am wrong.

@simonpasquier

This comment has been minimized.

Copy link
Member

simonpasquier commented Oct 3, 2018

@tariq1890 this metric applies to the /api/v1/read endpoint which can be used by external systems to read samples from Prometheus. One use case is described here: https://www.robustperception.io/accessing-data-from-prometheus-1-x-in-prometheus-2-0

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.