Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snapshot API no longer works without a `skip_head` parameter #4671

Closed
chester89 opened this Issue Sep 28, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@chester89
Copy link

chester89 commented Sep 28, 2018

Bug Report

What did you do?
Run curl -XPOST http://localhost:9090/api/v1/admin/tsdb/snapshot
What did you expect to see?
No errors, this worked ok in 2.3.2. Adding ?skip_head=false to the query fixed the problem
What did you see instead? Under which circumstances?
{"status":"error","errorType":"unavailable","error":"unable to parse boolean 'skip_head' argument: strconv.ParseBool: parsing \"\": invalid syntax"}
Environment

  • System information:
    Windows 7 SP 1

  • Prometheus version:
    2.4.2 revision c305ffa

@chester89

This comment has been minimized.

Copy link
Author

chester89 commented Sep 28, 2018

I think it'd be best to add a default value for skip_head parameter

@gouthamve

This comment has been minimized.

Copy link
Member

gouthamve commented Oct 4, 2018

Closed in #4674 and out in 2.4.3

@gouthamve gouthamve closed this Oct 4, 2018

@lock lock bot locked and limited conversation to collaborators Apr 2, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.