Skip to content

/prometheus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EC2 service discovery panics when OwnerID is nil #4684

Closed
simonpasquier opened this Issue Oct 1, 2018 · 2 comments

Comments

Assignees
No one assigned
Labels
component/service discovery kind/bug
Projects
None yet
Milestone
No milestone
2 participants
@simonpasquier @gouthamve
@simonpasquier
Copy link
Member

simonpasquier commented Oct 1, 2018

This only affects installations specifying the endpoint parameter in the EC2 SD configuration which means it doesn't concern users on AWS EC2.

prometheus/discovery/ec2/ec2.go

Lines 243 to 246 in 1c89984

labels := model.LabelSet{
ec2LabelOwnerID: model.LabelValue(*r.OwnerId),
ec2LabelInstanceID: model.LabelValue(*inst.InstanceId),
}

When r.OwnerId is nil, the server will crash.

@simonpasquier simonpasquier added kind/bug component/service discovery labels Oct 1, 2018

@simonpasquier

This comment has been minimized.

Sign in to view
Copy link
Member Author

simonpasquier commented Oct 1, 2018

Associated PR #4672
@gouthamve

This comment has been minimized.

Sign in to view
Copy link
Member

gouthamve commented Oct 4, 2018

Closed in #4672

@gouthamve gouthamve closed this Oct 4, 2018

@simonpasquier simonpasquier referenced this issue Oct 4, 2018

Merged

Adding private_dns_name to the list of ec2 labels which can be used i… #4693

@lock lock bot locked and limited conversation to collaborators Apr 2, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.