Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upPlease implement scraping via HTTPS (SSL/TLS) #474
Comments
beorn7
added
the
feature-request
label
Jan 27, 2015
This comment has been minimized.
This comment has been minimized.
|
Makes sense. Thanks for the input. |
This comment has been minimized.
This comment has been minimized.
|
@stapelberg I guess then you'll also need to be able to configure the username/password for the basic auth, so that the final URL will be something like |
This comment has been minimized.
This comment has been minimized.
|
Indeed, yes. For now, I’ve just set up a couple of static targets, but being able to specify userinfo and scheme would be great :). |
This comment has been minimized.
This comment has been minimized.
|
Cool, already started coding it. There are just some remaining code hygiene issues I need to figure out before doing a PR. |
beorn7
assigned
juliusv
Jan 27, 2015
This comment has been minimized.
This comment has been minimized.
m13
commented
Jan 29, 2015
|
+1 |
This comment has been minimized.
This comment has been minimized.
|
Just to give an update, I added TLS and basic auth functionality in this branch: https://github.com/prometheus/prometheus/commits/scheme-and-auth But to properly test it (disabling certificate checks only during tests, etc.), I think there's some more refactoring to do in how per-job configuration (auth, scheme, disabling TLS checks, ...) is propagated to the targets. I can't spend the time right now, but might later. That's why I'm not opening a PR for that yet. Anyways, if you're interested, you might want to give this a spin. I hope the changes in the |
This comment has been minimized.
This comment has been minimized.
|
From my POV, this issue is done. Prometheus 0.14.0 allows me to use the following config:
|
This comment has been minimized.
This comment has been minimized.
|
Indeed, thanks for pointing that out! Closing this issue. |
juliusv
closed this
Jun 23, 2015
gholt
referenced this issue
Mar 13, 2017
Open
Prometheus metrics should be provided via TLS and basic auth #267
simonpasquier
pushed a commit
to simonpasquier/prometheus
that referenced
this issue
Oct 12, 2017
This comment has been minimized.
This comment has been minimized.
fnkr
commented
Jan 8, 2019
•
|
Here is another example with a static scrape config: # https://prometheus:foo@myservice.example.com/prometheus_exporter
scrape_configs:
- job_name: My Service
scrape_interval: 1s
metrics_path: /prometheus_exporter
scheme: https
basic_auth:
username: prometheus
password: foo
static_configs:
- targets: ['myservice.example.com'] |
stapelberg commentedJan 27, 2015
For a small distributed application that I intend to monitor, we’re using HTTPS (with real certificates, so certificate verification is not an issue) and basic authentication instead of a separate private network, mostly because the setup should stay simple and the application runs on multiple different servers, distributed over the internet.
Therefore, could you please add a configuration option to the
JobConfigproto message? I’m using SRV record resolving, so I’d like to see e.g. aschemakey which defaults tohttp, but can be set tohttps.