Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove Makefile contraption. #476
Comments
beorn7
added
the
enhancement
label
Jan 27, 2015
beorn7
self-assigned this
Jan 27, 2015
This comment has been minimized.
This comment has been minimized.
|
Various people working on this right now. Unassigning myself for now. |
beorn7
removed their assignment
Mar 3, 2015
This comment has been minimized.
This comment has been minimized.
|
Who is working on this? We now have the Makefile.COMMON but it's not used in prometheus itself. #548 is a alternative to the Makefile triggered code-generation I assume. |
beorn7
referenced this issue
Jul 15, 2015
Closed
Bring Makefile in line with the Makefile used in other repos. #888
This comment has been minimized.
This comment has been minimized.
|
@fabxc I think we can close this now? |
This comment has been minimized.
This comment has been minimized.
|
Yes, syncing an included upstream Makefile did not turn out to be a scalable system. |
fabxc
closed this
Oct 10, 2015
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 24, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
beorn7 commentedJan 27, 2015
If you want to build with your own Go environment, you still have to trigger code-generation in certain cases. That's most comfortable with the Makefiles. But if you run make on top-level, it will download and install its own Go environment. If you run 'make' in a subdirectory with code generation, it will fail...