Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reevaluate #2357 #4820

Closed
logemann opened this Issue Nov 5, 2018 · 3 comments

Comments

Projects
None yet
3 participants
@logemann
Copy link

logemann commented Nov 5, 2018

Given all the feedback after the close, mostly arguing in one direction, how about re-evaluating #2357 ? Given the fact that a lot of mainstream open source frameworks have no problems with env var substitution, it still puzzles me why this should be a problem at all. There are most likely 1000 use cases for a feature like that. Especially in the docker context. Spring Boot wouldnt be so popular without that for sure because everyone uses it. They have even more in that regard, they also provide a way of definiting profiles and set them during start as another way of defining several environments.

@logemann logemann changed the title reevaluate https://github.com/prometheus/prometheus/issues/2357 reevaluate #2357 Nov 5, 2018

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Nov 5, 2018

We've discussed this many times, and there are no plans to change this. This is a configuration management issue, which is out of scope for Prometheus.

Dupe of #2357

@logemann

This comment has been minimized.

Copy link
Author

logemann commented Nov 5, 2018

Answer makes no sense but anyway.

@zakkg3

This comment has been minimized.

Copy link

zakkg3 commented Nov 14, 2018

workaround using confd, feel free to fork / use as inspiration :D
https://github.com/zakkg3/Prometheus-confd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.