Skip to content

/prometheus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why the alert always pending but not firing #4836

Closed
pulord opened this Issue Nov 8, 2018 · 3 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@pulord @simonpasquier
@pulord
Copy link

pulord commented Nov 8, 2018 •
edited

image
Query
sum by(errCode) (sum_over_time(weixin_biz_errs[5m])) > 60
Alert Rules

image

image

Runtime Info

image
@pulord

This comment has been minimized.

Sign in to view
Copy link
Author

pulord commented Nov 8, 2018 •
edited

delete currnet_value from labels， its works！

but why the alert firing must depend on the labels ？

maybe official update the alert trigger rule？

because its works before 2.0
@pulord

This comment has been minimized.

Sign in to view
Copy link
Author

pulord commented Nov 8, 2018

delete currnet_value from labels， its works！

but why the alert firing must depend on the labels ？

maybe official update the alert trigger rule？

because its works before 2.0

so the labels must fill by fixed value for alert rules now?
I must move current_value to annotations sector
@simonpasquier

This comment has been minimized.

Sign in to view
Copy link
Member

simonpasquier commented Nov 8, 2018

Yes, label values shouldn't change between evaluations otherwise it is equivalent to new alerts.

I'm closing it for now. If you have further questions, please use our user mailing list, which you can also search.

@simonpasquier simonpasquier closed this Nov 8, 2018

@LucasRoesler LucasRoesler referenced this issue Feb 17, 2019

Closed

Potential issues with AlertManager #372

LucasRoesler added a commit to LucasRoesler/faas-netes that referenced this issue Feb 17, 2019

@LucasRoesler
Remove alert value from the alert labels 
**What**
- Removes the `alert` label in the scale-up alert
- Updates the annotaitons to use the `function_name` label instead of
the `instance` label that was removed.
- Per prometheus/prometheus#4836 and the related mailing list discussion
https://groups.google.com/d/msg/prometheus-users/7Ul6ngc7Ogs/j_YDszV5BwAJ
the alert value should not be included in the alert labels otherwise
each calculation of the alert is treated like a new alert and then the
use of `for 5s` will not behave as expected.
- Attemps to resolve openfaas#372

Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
Verified
This commit was signed with a verified signature.
@LucasRoesler LucasRoesler Lucas
GPG key ID: E21B79114F452942 Learn about signing commits
Loading status checks…
cb52df1

@LucasRoesler LucasRoesler referenced this issue Feb 17, 2019

Merged

Fix remove value from scaling alert definition #373

6 of 11 tasks complete

alexellis added a commit to openfaas/faas-netes that referenced this issue Feb 18, 2019

@LucasRoesler @alexellis
Remove alert value from the alert labels 
**What**
- Removes the `alert` label in the scale-up alert
- Updates the annotaitons to use the `function_name` label instead of
the `instance` label that was removed.
- Per prometheus/prometheus#4836 and the related mailing list discussion
https://groups.google.com/d/msg/prometheus-users/7Ul6ngc7Ogs/j_YDszV5BwAJ
the alert value should not be included in the alert labels otherwise
each calculation of the alert is treated like a new alert and then the
use of `for 5s` will not behave as expected.
- Attemps to resolve #372

Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
99b56da

LucasRoesler added a commit to LucasRoesler/faas that referenced this issue Feb 21, 2019

@LucasRoesler
Upgrade prom and alert manager to 2.7.1 and 0.16.1 
**What**
- Removes the `alert` label in the scale-up alert
- Updates the annotaitons to use the `function_name` label instead of
the `instance` label that was removed.
- Per prometheus/prometheus#4836 and the related mailing list discussion
https://groups.google.com/d/msg/prometheus-users/7Ul6ngc7Ogs/j_YDszV5BwAJ
the alert value should not be included in the alert labels otherwise
each calculation of the alert is treated like a new alert and then the
use of `for 5s` will not behave as expected.
- Ports the resoltuion openfaas/faas-netes#372

Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
Verified
This commit was signed with a verified signature.
@LucasRoesler LucasRoesler Lucas
GPG key ID: E21B79114F452942 Learn about signing commits
Loading status checks…
721beb8

@LucasRoesler LucasRoesler referenced this issue Feb 21, 2019

Merged

Upgrade prom and alert manager to 2.7.1 and 0.16.1 #1098

6 of 11 tasks complete

alexellis added a commit to openfaas/faas that referenced this issue Feb 21, 2019

@LucasRoesler @alexellis
Upgrade prom and alert manager to 2.7.1 and 0.16.1 
**What**
- Removes the `alert` label in the scale-up alert
- Updates the annotaitons to use the `function_name` label instead of
the `instance` label that was removed.
- Per prometheus/prometheus#4836 and the related mailing list discussion
https://groups.google.com/d/msg/prometheus-users/7Ul6ngc7Ogs/j_YDszV5BwAJ
the alert value should not be included in the alert labels otherwise
each calculation of the alert is treated like a new alert and then the
use of `for 5s` will not behave as expected.
- Ports the resoltuion openfaas/faas-netes#372

Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
Loading status checks…
3bcc10a

Kiku-git added a commit to Kiku-git/faas that referenced this issue Mar 7, 2019

@LucasRoesler @Kiku-git
Upgrade prom and alert manager to 2.7.1 and 0.16.1 
**What**
- Removes the `alert` label in the scale-up alert
- Updates the annotaitons to use the `function_name` label instead of
the `instance` label that was removed.
- Per prometheus/prometheus#4836 and the related mailing list discussion
https://groups.google.com/d/msg/prometheus-users/7Ul6ngc7Ogs/j_YDszV5BwAJ
the alert value should not be included in the alert labels otherwise
each calculation of the alert is treated like a new alert and then the
use of `for 5s` will not behave as expected.
- Ports the resoltuion openfaas/faas-netes#372

Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
9fe3154
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.