Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upYAML configuration output is not correctly indented #4846
Comments
This comment has been minimized.
This comment has been minimized.
|
Is it invalid YAML, or is the linter being over-sensitive? |
This comment has been minimized.
This comment has been minimized.
|
Though not complying with the linter's rules, the YAML exposed by Prometheus is perfectly valid. There isn't much we can do here as we rely on an external library for YAML serialization/deserialization. |
simonpasquier
closed this
Nov 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
kaihendry commentedNov 9, 2018
Proposal
I'm often terrorised by incorrect YAML indentation and I noticed what Prometheus outputs in /config isn't perfect strictly speaking.
Bug Report
What I did: Copy the configuration shown on /config
Expected: A valid YAML document
What happened instead: yamllint 1.12.1 strictly complain about the document
Prometheus version: 2.5
https://s.natalian.org/2018-11-09/yaml-indentation.mp4