Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YAML configuration output is not correctly indented #4846

Closed
kaihendry opened this Issue Nov 9, 2018 · 2 comments

Comments

Projects
None yet
3 participants
@kaihendry
Copy link

kaihendry commented Nov 9, 2018

Proposal

I'm often terrorised by incorrect YAML indentation and I noticed what Prometheus outputs in /config isn't perfect strictly speaking.

Bug Report

  • What I did: Copy the configuration shown on /config

  • Expected: A valid YAML document

  • What happened instead: yamllint 1.12.1 strictly complain about the document

  • Prometheus version: 2.5

https://s.natalian.org/2018-11-09/yaml-indentation.mp4

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Nov 9, 2018

Is it invalid YAML, or is the linter being over-sensitive?

@simonpasquier

This comment has been minimized.

Copy link
Member

simonpasquier commented Nov 19, 2018

Though not complying with the linter's rules, the YAML exposed by Prometheus is perfectly valid. There isn't much we can do here as we rely on an external library for YAML serialization/deserialization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.