Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consul job rename/relabel not working with 2.5.0 #4853

Closed
raypettersen opened this Issue Nov 10, 2018 · 10 comments

Comments

Projects
None yet
5 participants
@raypettersen
Copy link

raypettersen commented Nov 10, 2018

Proposal

Use case. Why is this important?
Grouping of exporters when using consul is broken for job rename.

Bug Report

What did you do?
Upgraded to latest 2.5 version. All exporters discovered with consul ended up with a single job name instead of rename for each exporter which was working flawlessly with 1.8.0

What did you expect to see?
Continued renaming of job name, so all discovered exporters are sorted correctly in the prometheus view. Downgrading to 2.4.3 resolved the issue.

  • Prometheus version:

2.5.0

@raypettersen

This comment has been minimized.

Copy link
Author

raypettersen commented Nov 10, 2018

        regex: '(.*)'
        target_label: 'job'
        replacement: '$1'
@hoffie

This comment has been minimized.

Copy link

hoffie commented Nov 11, 2018

Do you see any actual problems (i.e. unexpected changes in the database) or could this be just explained by the announced, changed UI grouping in 2.5.0?

@raypettersen

This comment has been minimized.

Copy link
Author

raypettersen commented Nov 11, 2018

It's just the gui as far as I can see. Likely related to the announcement. What's the fix for getting proper grouping when using consul/sd? Right now everything is grouped under "consul". I'd like to get the old behavior which lets me get exporters grouped by name.

@simonpasquier

This comment has been minimized.

Copy link
Member

simonpasquier commented Nov 12, 2018

Indeed the UI layout for targets has changed in 2.5.0. To be honest, it wasn't really intentional but positively welcomed by users that noticed the new layout. On the other hand, I see how the change can be annoying for you. What if targets inside a scrape configuration were grouped by job?

@MustaphaB1

This comment has been minimized.

Copy link

MustaphaB1 commented Nov 14, 2018

Also having this same issue.. will this be fixed or is downgrading to 2.4.3 the only option.

@simonpasquier

This comment has been minimized.

Copy link
Member

simonpasquier commented Nov 22, 2018

I've sent #4898 that will at least sort targets by job then instance labels.

@zbindenren

This comment has been minimized.

Copy link

zbindenren commented Dec 31, 2018

Also having this same issue.. will this be fixed or is downgrading to 2.4.3 the only option.

Downgrading to 2.4 is the only option to get the same behavior.

@raypettersen

This comment has been minimized.

Copy link
Author

raypettersen commented Dec 31, 2018

Problem persists with 2.5, with "standard" consul config.

@zbindenren

This comment has been minimized.

Copy link

zbindenren commented Dec 31, 2018

@raypettersen the problem also persists with 2.6. And there are no plans to go back to the
<= 2.4 behavior. See #4898 for more information.

@raypettersen

This comment has been minimized.

Copy link
Author

raypettersen commented Dec 31, 2018

Yes, we're staying on 2.4.3 until we find a workaround. I thought #4898 would resolve the problem, but it didn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.