Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upConsul job rename/relabel not working with 2.5.0 #4853
Comments
This comment has been minimized.
This comment has been minimized.
|
This comment has been minimized.
This comment has been minimized.
hoffie
commented
Nov 11, 2018
|
Do you see any actual problems (i.e. unexpected changes in the database) or could this be just explained by the announced, changed UI grouping in 2.5.0? |
This comment has been minimized.
This comment has been minimized.
|
It's just the gui as far as I can see. Likely related to the announcement. What's the fix for getting proper grouping when using consul/sd? Right now everything is grouped under "consul". I'd like to get the old behavior which lets me get exporters grouped by name. |
This comment has been minimized.
This comment has been minimized.
|
Indeed the UI layout for targets has changed in 2.5.0. To be honest, it wasn't really intentional but positively welcomed by users that noticed the new layout. On the other hand, I see how the change can be annoying for you. What if targets inside a scrape configuration were grouped by |
simonpasquier
added
the
component/ui
label
Nov 13, 2018
This comment has been minimized.
This comment has been minimized.
MustaphaB1
commented
Nov 14, 2018
|
Also having this same issue.. will this be fixed or is downgrading to 2.4.3 the only option. |
simonpasquier
referenced this issue
Nov 22, 2018
Merged
web: group targets by job then instance #4898
This comment has been minimized.
This comment has been minimized.
|
I've sent #4898 that will at least sort targets by job then instance labels. |
simonpasquier
closed this
in
#4898
Nov 30, 2018
This comment has been minimized.
This comment has been minimized.
zbindenren
commented
Dec 31, 2018
Downgrading to 2.4 is the only option to get the same behavior. |
This comment has been minimized.
This comment has been minimized.
|
Problem persists with 2.5, with "standard" consul config. |
This comment has been minimized.
This comment has been minimized.
zbindenren
commented
Dec 31, 2018
|
@raypettersen the problem also persists with 2.6. And there are no plans to go back to the |
This comment has been minimized.
This comment has been minimized.
|
Yes, we're staying on 2.4.3 until we find a workaround. I thought #4898 would resolve the problem, but it didn't. |
raypettersen commentedNov 10, 2018
Proposal
Use case. Why is this important?
Grouping of exporters when using consul is broken for job rename.
Bug Report
What did you do?
Upgraded to latest 2.5 version. All exporters discovered with consul ended up with a single job name instead of rename for each exporter which was working flawlessly with 1.8.0
What did you expect to see?
Continued renaming of job name, so all discovered exporters are sorted correctly in the prometheus view. Downgrading to 2.4.3 resolved the issue.
2.5.0