Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binary operators should support by clauses #488

Closed
brian-brazil opened this Issue Jan 29, 2015 · 4 comments

Comments

Projects
None yet
3 participants
@brian-brazil
Copy link
Member

brian-brazil commented Jan 29, 2015

Sometimes the LHS and RHS don't quite have the same labels, but are still matchable 1-to-1. Allowing by clauses on binary operators would allow for this use case.
#393 is a more advanced case where you want to do a 1-to-many match.

@brian-brazil

This comment has been minimized.

Copy link
Member Author

brian-brazil commented Feb 20, 2015

More particularly if I have

a{label=foo,otherlabel=z} 1
b{label=foo} 2

then a + by (label) b should produce:

{label=foo} 3

and if I have

a{label=foo,otherlabel=z} 1
a{label=foo,otherlabel=x} 1
b{label=foo} 2

the I'd get an error of some form as this usually indicates an error in the expression (#393 covers the case where you explicitly want this to work).

@beorn7

This comment has been minimized.

Copy link
Member

beorn7 commented Feb 20, 2015

Thanks for the explanation.

Since you are planning a similar thing for unary operators AKA functions, how would things work there?

@juliusv

This comment has been minimized.

Copy link
Member

juliusv commented Mar 3, 2015

Done by @fabxc in #554.

@juliusv juliusv closed this Mar 3, 2015

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.