Skip to content

/prometheus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus should fail if Azure authentication parameters are missing #4900

Closed
simonpasquier opened this Issue Nov 23, 2018 · 1 comment

Comments

Assignees
No one assigned
Labels
component/service discovery help wanted low hanging fruit
Projects
None yet
Milestone
No milestone
2 participants
@simonpasquier @supernan1994
@simonpasquier
Copy link
Member

simonpasquier commented Nov 23, 2018

Follow up of #4590

Prometheus starts with the following configuration snippet but the Azure SD mechanism will fail to run (log: "Unable to refresh during Azure discovery" err="could not create Azure client: parameter 'clientID' cannot be empty"). It would be better for Prometheus to fail hard.

- job: azure
  azure_sd_configs:
  - subscription_id: xxx

@simonpasquier simonpasquier added help wanted low hanging fruit component/service discovery labels Nov 23, 2018

@supernan1994

This comment has been minimized.

Sign in to view
Copy link
Contributor

supernan1994 commented Nov 24, 2018

I'm working on it

@supernan1994 supernan1994 referenced this issue Nov 24, 2018

Merged

discovery/azure: Fail hard when Azure authentication parameters are missing #4907

@simonpasquier simonpasquier closed this in #4907 Nov 29, 2018

@simonpasquier simonpasquier modified the milestone: v2.6.0 Nov 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.