Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export value of sample_limit #4933

Closed
svend opened this Issue Nov 29, 2018 · 2 comments

Comments

Projects
None yet
2 participants
@svend
Copy link
Contributor

svend commented Nov 29, 2018

Proposal

This is a feature request.

Export value of sample_limit so that alerts can be set for scrapes that are approaching the limit without hard-coding the limit in the alert.

I checked the exported metrics on Prometheus 2.3.2 and didn't see this currently exported.

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Nov 29, 2018

This would be a new additional sample for every single target, which is not something to add lightly from a resource usage standpoint. It's expected that you'd know the values you're using, and not have many of them, so this could be handled fairly sanely via configuration management.

@svend

This comment has been minimized.

Copy link
Contributor Author

svend commented Nov 29, 2018

That's a good point. I had forgotten that the limit was set per scape config, not globally.

@svend svend closed this Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.