Skip to content

/prometheus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Querier.Select now returns a third thing 'warnings' - can't pass golint... #4956

Closed
tomwilkie opened this Issue Dec 4, 2018 · 1 comment

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@tomwilkie @brian-brazil
@tomwilkie
Copy link
Member

tomwilkie commented Dec 4, 2018

As of #4832 we've added a third parameter to Querier.Select, but this makes it impossible to implement this interface in a golint clean way:

./pkg/querier/querier.go:114:1: error should be the last type when returning multiple items

We'd like to stay golint clean in Cortex; anyone object to me making error last in that interface? And perhaps adding golint to our CI...

@tomwilkie tomwilkie referenced this issue Dec 4, 2018

Merged

Update Prometheus & TSDB #1139

@brian-brazil

This comment has been minimized.

Sign in to view
Copy link
Member

brian-brazil commented Dec 4, 2018

Sure, go ahead. You'll need to touch it in quite a few places.

@tomwilkie tomwilkie referenced this issue Jan 2, 2019

Merged

Move err to be the last return value from storage.Select. #5054

@tomwilkie tomwilkie closed this in #5054 Jan 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.