Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upCORS: Leave user configure CORS in prometheus.yml #5010
Comments
This comment has been minimized.
This comment has been minimized.
|
Per previous discussions, this would make more sense as a flag. |
This comment has been minimized.
This comment has been minimized.
|
I'll try to send a PR for this one today. |
geekodour
referenced this issue
Jan 19, 2019
Merged
corrected regex string check for anyorigin(*) #5117
This comment has been minimized.
This comment has been minimized.
|
looks like the two PR's fix this, can we close? |
brian-brazil
closed this
Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
aloababa commentedDec 18, 2018
•
edited
According to prometheus code Allowed Origin is always set to '*'.
var corsHeaders = map[string]string{ "Access-Control-Allow-Headers": "Accept, Authorization, Content-Type, Origin", "Access-Control-Allow-Methods": "GET, OPTIONS", "Access-Control-Allow-Origin": "*", "Access-Control-Expose-Headers": "Date", }So what if i want a single allowed origin ?
It would be nice to allow user configure allowed origins or disable cors in prometheus.yml