Skip to content

/prometheus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The Makefile magic that assembles the Go download address does not work on all architectures. #503

Closed
rkubik opened this Issue Feb 4, 2015 · 9 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@rkubik @beorn7 @juliusv @gkoz
@rkubik
Copy link

rkubik commented Feb 4, 2015

Makefile.INCLUDE has:
ARCH=$(shell uname -m)

It uses this architecture string to pull from https://golang.org/dl/. Since go1.4.1.linux-i686.tar.gz does not exist the build will fail. It should pull go1.4.1.linux-386.tar.gz instead.

@beorn7 beorn7 added the bug label Feb 4, 2015

@beorn7

This comment has been minimized.

Sign in to view
Copy link
Member

beorn7 commented Feb 4, 2015

Oops... we need to fix that in other makefiles, too.
@beorn7

This comment has been minimized.

Sign in to view
Copy link
Member

beorn7 commented Feb 5, 2015

Apparently, the same issue happens if you run on Windows... We should check the ARCH magic for all platforms supported by Go. I'll change the title of this issue accordingly.

@beorn7 beorn7 changed the title Building on architecture i686 results in failed GoLang fetch The Makefile magic that assembles the Go download address does not work on all architectures. Feb 5, 2015

@beorn7 beorn7 referenced this issue Feb 5, 2015

Closed

Make it run on MS Windows. #505

@juliusv juliusv referenced this issue Feb 5, 2015

Merged

Fix Go download path for i686 architecture. #507

@juliusv

This comment has been minimized.

Sign in to view
Copy link
Member

juliusv commented Feb 5, 2015

@rkubik Could you try if #507 fixes this? We don't have any i686 around...
@gkoz

This comment has been minimized.

Sign in to view
Copy link

gkoz commented Feb 5, 2015

While there, you might want to fix GOOS to do s/FreeBSD/freebsd/ too. Oh, and 386 is i386 on freebsd.
@juliusv

This comment has been minimized.

Sign in to view
Copy link
Member

juliusv commented Feb 5, 2015

@gkoz Thanks for pointing that out. Added the GOOS fix to the PR. Not sure what you mean with s/386/i386/? The links I see on https://golang.org/dl/ contains 386?

juliusv added a commit that referenced this issue Feb 5, 2015

@juliusv
Fix Go download path for x86-based architectures. 
This fixes #503.
753113f
@gkoz

This comment has been minimized.

Sign in to view
Copy link

gkoz commented Feb 5, 2015

@juliusv I think the i%86 pattern in you PR should work for freebsd too.
@rkubik

This comment has been minimized.

Sign in to view
Copy link
Author

rkubik commented Feb 5, 2015

@juliusv Your #507 patch works on i686. Thank you.

@juliusv juliusv closed this in #507 Feb 5, 2015

@juliusv

This comment has been minimized.

Sign in to view
Copy link
Member

juliusv commented Feb 5, 2015

@rkubik @gkoz Thanks! Merged.

simonpasquier pushed a commit to simonpasquier/prometheus that referenced this issue Oct 12, 2017

@juliusv
Merge pull request prometheus#503 from prometheus/grobie/clarify-dns-… 
…srv-sd

Clarify DNS service discovery relationship to DNS-SD
d5b0029
@lock

This comment has been minimized.

Sign in to view
Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.