Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upServer does not shut down cleanly when rules file has syntax errors. #504
Comments
beorn7
added
the
bug
label
Feb 5, 2015
beorn7
self-assigned this
Feb 5, 2015
This comment has been minimized.
This comment has been minimized.
|
Other errors (e.g. if the web.listen address cannot be bound to) may have the same effect. |
This comment has been minimized.
This comment has been minimized.
|
The rule issue should be fixed by #694 as we no longer shutdown if rules don't parse. |
This comment has been minimized.
This comment has been minimized.
|
@fabxc But this previously only affected startups - and we still want to die when the configs/rules can't be parsed upon startup, no? |
This comment has been minimized.
This comment has been minimized.
|
Yes, that's what I was talking about with @beorn7 before. We won't get around restructuring the storage startup. You can find an attempt in this branch. No background goroutines are started until after |
fabxc
referenced this issue
May 19, 2015
Merged
Clean storage shutdown on startup errors, require initial config #704
This comment has been minimized.
This comment has been minimized.
|
Fixed by #704 |
fabxc
closed this
May 19, 2015
simonpasquier
pushed a commit
to simonpasquier/prometheus
that referenced
this issue
Oct 12, 2017
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 24, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
beorn7 commentedFeb 5, 2015
Should be easy to fix... either load rules before starting the storage, or shut down storage cleanly if rules don't parse.