Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server does not shut down cleanly when rules file has syntax errors. #504

Closed
beorn7 opened this Issue Feb 5, 2015 · 6 comments

Comments

Projects
None yet
3 participants
@beorn7
Copy link
Member

beorn7 commented Feb 5, 2015

Should be easy to fix... either load rules before starting the storage, or shut down storage cleanly if rules don't parse.

@beorn7 beorn7 added the bug label Feb 5, 2015

@beorn7 beorn7 self-assigned this Feb 5, 2015

@beorn7

This comment has been minimized.

Copy link
Member Author

beorn7 commented Feb 6, 2015

Other errors (e.g. if the web.listen address cannot be bound to) may have the same effect.

@fabxc

This comment has been minimized.

Copy link
Member

fabxc commented May 15, 2015

The rule issue should be fixed by #694 as we no longer shutdown if rules don't parse.

@juliusv

This comment has been minimized.

Copy link
Member

juliusv commented May 18, 2015

@fabxc But this previously only affected startups - and we still want to die when the configs/rules can't be parsed upon startup, no?

@fabxc

This comment has been minimized.

Copy link
Member

fabxc commented May 18, 2015

Yes, that's what I was talking about with @beorn7 before. We won't get around restructuring the storage startup.

You can find an attempt in this branch.

No background goroutines are started until after Storage.Start() knows that it can return without an error.
Chances are I missed something essential, so the general approach has to be verified by @beorn7 :)

@fabxc

This comment has been minimized.

Copy link
Member

fabxc commented May 19, 2015

Fixed by #704

@fabxc fabxc closed this May 19, 2015

simonpasquier pushed a commit to simonpasquier/prometheus that referenced this issue Oct 12, 2017

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.