Add rule_group label to prometheus_rule_evaluation_failures_total and rule_evaluations_total

[sylr]

prometheus/rules/manager/manager.go

Line 242 in 9a4ca68

evalFailures.Inc()

Could we consider adding a rule_name label to this metric to know which rule fails to be evaluated ?

[brian-brazil]

That's been considered previously. It'd be too high cardinality, and rule names are not required to be unique. It will be logged, and there's a PR out to add the rule group to this metric.

…

On Wed, 2 Jan 2019 at 15:39, Sylvain Rabot ***@***.***> wrote: https://github.com/prometheus/prometheus/blob/9a4ca68a610592e33b6b0231aea5b7579d76b7c5/rules/manager/manager.go#L242 Could we consider adding a rule_name label to this metric to know which rule fails to be evaluated ? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#5055>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AGyTdvv4jLVHa2zTWJGHLKVM9jhlLdwCks5u_NK_gaJpZM4Zm0oJ> .

-- Brian Brazil www.robustperception.io