Skip to content

/prometheus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to use rules.NewGroup without registering metrics twice. #5058

Closed
tomwilkie opened this Issue Jan 3, 2019 · 0 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@tomwilkie
@tomwilkie
Copy link
Member

tomwilkie commented Jan 3, 2019

Since #4961, there is no way to use rules.NewGroup without registering the metrics twice, because the metrics field of ManagerOptions is not public.

This is a problem for Cortex, see cortexproject/cortex#1154

Any objections to making metrics and newGroupMetrics public?

@tomwilkie tomwilkie referenced this issue Jan 3, 2019

Merged

Expose rules.NewGroupMetrics and rules.Metrics. #5059

@tomwilkie tomwilkie closed this in #5059 Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.