Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promtool test rules - out of order sample on v2.6.0 but worked on v.2.5.0 #5064

Closed
kentsanggds opened this Issue Jan 4, 2019 · 5 comments

Comments

Projects
None yet
4 participants
@kentsanggds
Copy link

kentsanggds commented Jan 4, 2019

Bug Report

What did you do?
Ran promtool test rules <rule test file>

Rules file - https://github.com/alphagov/prometheus-aws-configuration-beta/blob/4dfb2058b805bb6dee32eb4fbc129d4be14bf70c/terraform/modules/app-ecs-services/config/alerts-tests/test-observe-alerts.yml

What did you expect to see?

Tests passing, they were passing on Prometheus v2.5.0

What did you see instead? Under which circumstances?

Tests failed with - out of order sample

Environment

  • System information:

    insert output of uname -srm here

Darwin 17.7.0 x86_64

  • Prometheus version:

    insert output of prometheus --version here

prometheus, version 2.6.0 (branch: non-git, revision: non-git)
  build user:       brew@HighSierra.local
  build date:       20181220-02:53:59
  go version:       go1.11.4
@codesome

This comment has been minimized.

Copy link
Member

codesome commented Jan 4, 2019

#4851 might possibly be the reason, not sure, will have a look at it soon.

@simonpasquier

This comment has been minimized.

Copy link
Member

simonpasquier commented Jan 16, 2019

Closed by #5069

@kentsanggds

This comment has been minimized.

Copy link
Author

kentsanggds commented Jan 16, 2019

has this been fixed?

@codesome

This comment has been minimized.

Copy link
Member

codesome commented Jan 16, 2019

@kentsanggds Yes, the fix is included in v2.6.1 (released yesterday).

@kentsanggds

This comment has been minimized.

Copy link
Author

kentsanggds commented Jan 16, 2019

Great, will try it out

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.