Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upPromtool test rules - out of order sample on v2.6.0 but worked on v.2.5.0 #5064
Comments
This comment has been minimized.
This comment has been minimized.
|
#4851 might possibly be the reason, not sure, will have a look at it soon. |
codesome
referenced this issue
Jan 5, 2019
Merged
Empty slice after last append in promql test LazyLoader #5069
krasi-georgiev
added
component/promql
component/promtool
and removed
component/promql
labels
Jan 7, 2019
This comment has been minimized.
This comment has been minimized.
|
Closed by #5069 |
simonpasquier
closed this
Jan 16, 2019
This comment has been minimized.
This comment has been minimized.
|
has this been fixed? |
This comment has been minimized.
This comment has been minimized.
|
@kentsanggds Yes, the fix is included in |
This comment has been minimized.
This comment has been minimized.
|
Great, will try it out |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
kentsanggds commentedJan 4, 2019
Bug Report
What did you do?
Ran
promtool test rules <rule test file>Rules file - https://github.com/alphagov/prometheus-aws-configuration-beta/blob/4dfb2058b805bb6dee32eb4fbc129d4be14bf70c/terraform/modules/app-ecs-services/config/alerts-tests/test-observe-alerts.yml
What did you expect to see?
Tests passing, they were passing on Prometheus v2.5.0
What did you see instead? Under which circumstances?
Tests failed with -
out of order sampleEnvironment
System information:
insert output of
uname -srmhereDarwin 17.7.0 x86_64Prometheus version:
insert output of
prometheus --versionhere