Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upMarathon_SD Host Target Address when using Virtual Networks #5067
Comments
Smithx10
referenced this issue
Jan 5, 2019
Closed
Added External Flag to Marathon_SD service discovery #5068
This comment has been minimized.
This comment has been minimized.
|
After receiving feedback from @brian-brazil in #5068 I have added the meta_marathon_host label to the marathon_sd configuration. This should be addressed in https://github.com/Smithx10/prometheus/tree/marathon_sd_host_md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Smithx10 commentedJan 5, 2019
Proposal
While using the Marathon_SD configuration with a prometheus server external to Mesosphere Cluster ( which uses marathon ) I ran into a situation where the Port's Target Address would use the Virtual IP instead of the HOST IP, which is fair if the Prometheus Server was internal to the DC/OS cluster.
I added an external option to the config which will bias the ports Target Address to the Host IP which is routable externally. If omitted, marathon_sd behaves the same as before. So this should be a non breaking change.
Smithx10@2780ee5
In IRC someone suggested relabelling, but I don't believe there is any meta labels that would facilitate this behaviour.
https://prometheus.io/docs/prometheus/latest/configuration/configuration/#marathon_sd_config