Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make hash collisions less likely. #509

Closed
beorn7 opened this Issue Feb 5, 2015 · 6 comments

Comments

Projects
None yet
4 participants
@beorn7
Copy link
Member

beorn7 commented Feb 5, 2015

The 64bit hashes we use currently have an uncomfortably high probability to cause a hash collision on very large servers. Investigate remedies (either in hash generation or size...).

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Feb 5, 2015

Long term I think we should be looking at solutions that don't depend on a lack of hash collisions.

@beorn7

This comment has been minimized.

Copy link
Member Author

beorn7 commented May 11, 2015

FIxed by #682

@beorn7 beorn7 closed this May 11, 2015

@sanga

This comment has been minimized.

Copy link

sanga commented May 20, 2015

Seems like the text at the bottom of this page requires some updating btw: http://prometheus.io/docs/operating/storage/

@fabxc

This comment has been minimized.

Copy link
Member

fabxc commented May 20, 2015

The docs are already updated, just has to go live. Which is temporarily
blocked, which is my fault.

On Wed, May 20, 2015 at 8:31 AM Tim Sampson notifications@github.com
wrote:

Seems like the text at the bottom of this page requires some updating btw:
http://prometheus.io/docs/operating/storage/


Reply to this email directly or view it on GitHub
#509 (comment)
.

@sanga

This comment has been minimized.

Copy link

sanga commented May 20, 2015

Cool. Cheers

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.