Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upCatch when two targets are relabelled to the same labels #5136
Comments
This comment has been minimized.
This comment has been minimized.
|
I would rather not scrape the targets than creating just one scrape config, as two instances can get the same labelset if you overwrite the metrics. Also, we can have the issue with honor_label: true anyway .. |
This comment has been minimized.
This comment has been minimized.
|
This is about target labels rather than scraped labels.
I don't think that'll be practical, which one would you choose? |
simonpasquier
added
kind/enhancement
component/scraping
labels
Feb 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
gouthamve commentedJan 25, 2019
When two different targets end up with the same labels after relabelling, two scrape loops are created and OOO ingestion errors are logged.
We should ideally catch this and log it. And create only one scrape loop per target labelset.
This might break some setups as people might be abusing it already and are safe if the two targets don't have any common metrics.