Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch when two targets are relabelled to the same labels #5136

Open
gouthamve opened this Issue Jan 25, 2019 · 2 comments

Comments

Projects
None yet
4 participants
@gouthamve
Copy link
Member

gouthamve commented Jan 25, 2019

When two different targets end up with the same labels after relabelling, two scrape loops are created and OOO ingestion errors are logged.

We should ideally catch this and log it. And create only one scrape loop per target labelset.

This might break some setups as people might be abusing it already and are safe if the two targets don't have any common metrics.

@roidelapluie

This comment has been minimized.

Copy link
Contributor

roidelapluie commented Jan 25, 2019

I would rather not scrape the targets than creating just one scrape config, as two instances can get the same labelset if you overwrite the metrics.

Also, we can have the issue with honor_label: true anyway ..

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Jan 25, 2019

This is about target labels rather than scraped labels.

And create only one scrape loop per target labelset.

I don't think that'll be practical, which one would you choose?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.