Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no option for zero-based graphs #520

Open
robey opened this Issue Feb 10, 2015 · 9 comments

Comments

Projects
None yet
9 participants
@robey
Copy link
Contributor

robey commented Feb 10, 2015

I thought there was consensus that graphs should start at 0 on the Y axis to avoid misinterpretation, but a quick google search shows that there's not total agreement on that.

So, I would like the option to make the graph zero-based, without forcing everyone else to agree. :)

For some stats (like "users online"), the graph may stay flat for hours at a time. Currently, prometheus will draw such a graph as blank, with a minimal Y range, and a single line at the baseline where it's effectively invisible.

@juliusv

This comment has been minimized.

Copy link
Member

juliusv commented Feb 10, 2015

Agreed. I believe 0-based is the default in PromDash (vs. Prometheus itself), though it's possible to manually set a Y-axis range (but no option to simply dynamically clamp the Y-axis to the available values).

0-based Y-axes have the problem that very large counters will just look like flat lines even if they're increasing rapidly. But yeah, the reverse problems also exist.

So I think this might actually be worth another UI button, both in Prometheus and in PromDash.

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Feb 10, 2015

@juliusv

This comment has been minimized.

Copy link
Member

juliusv commented Feb 10, 2015

Yeah, it's less about the graphing library support than about the question of what UI elements to add to get a balance between UI clutter and really needed features (for the server-side built-in graphing at least).

@brian-brazil

This comment has been minimized.

Copy link
Member

brian-brazil commented Feb 10, 2015

I think for /graph we should do something a bit more reasonable when all the values are the same, such as say making the main and max 10% either side of the value.

@discordianfish

This comment has been minimized.

Copy link
Member

discordianfish commented Mar 25, 2016

I just realize how problematic this can be: "Peaks in the metrics are lower than they appear" :)
Do we have consensus how it should look like? Making it 10% will help with the invisible steady metric but won't change that it's sometime visually misleading. I guess a simply checkbox with whatever default would make most sense since I believe there are scenarios for both.

@matthiasr

This comment has been minimized.

Copy link
Contributor

matthiasr commented Nov 22, 2016

another case: stacked graphs should always include the zero line. Right now I'm looking at a stacking of 5 up == 1 and it's … weird.

prometheus_time_series_collection_and_processing_server

@theophani

This comment has been minimized.

Copy link

theophani commented Nov 22, 2016

@matthiasr A stacked graph was exactly what I was looking at when we discussed this yesterday in our company channel. Maybe that is a nice mini-change.

In this graph, I was trying to understand the contribution that the green area contributed to the whole. For a moment, I was convinced it contributed more than half.

screen shot 2016-11-22 at 11 02 03

I understand the desire to see “the interesting” part of the graph in detail, but I think that should be an active choice, not the other way around.

@discordianfish

This comment has been minimized.

Copy link
Member

discordianfish commented Nov 22, 2016

This seems easy to fix. Are we in agreement that it should be changed? And how is it suppose to look? Just another button beside [ ] Stacked? I'd also say we make it default for all graphs.

@matthiasr

This comment has been minimized.

Copy link
Contributor

matthiasr commented Nov 22, 2016

👍

simonpasquier pushed a commit to simonpasquier/prometheus that referenced this issue Oct 12, 2017

Merge pull request prometheus#520 from alex/patch-1
Update kubernetes link to use the new github org

derekmarcotte added a commit to derekmarcotte/prometheus that referenced this issue Nov 2, 2017

Make 0 the default for y-axis, add auto-y toggle.
This is to specifically address prometheus#520.  The option is made default.

The wording auto-y was picked because a default item should be "off" in
the UI.  It would look strange if it were '0-based', and auto-on beside
stacked.

Additionally, stacked implies zero based, so clicking either button may
toggle the other button.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.