Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign up'Unhealthy' Targets filter not filtering out all 'Healthy' Targets #5219
Comments
This comment has been minimized.
This comment has been minimized.
|
@smarch2 this looks good. If you have the patch ready, can you go ahead and open a PR? |
simonpasquier
added
the
component/ui
label
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
smarch2 commentedFeb 14, 2019
Proposal
Use case. Why is this important?
When selecting 'Unhealthy' on the Targets Page, Jobs are only hidden if all the Targets within that Job are 'Healthy'. If a Job contains many Targets but only contains one 'Unhealthy' Target, all the 'Healthy' Targets will still be visible.
It would be more manageable and user friendly, in particular when there are many Targets, to only show the 'Unhealthy' Targets.
This was touched upon in #4319.
I have coded a fix for this, if seen as beneficial, I will submit a Pull Request for review.
Bug Report
What did you do?
Filter the Targets by 'Unhealthy' on the Targets Page.
What did you expect to see?
Only 'Unhealthy' Targets visible (Prometheus job gets hidden).
What did you see instead? Under which circumstances?
All the other 'Healthy' Targets within a Job that contains 'Unhealthy' Targets (Prometheus job is hidden, but still the 'Healthy' Targets in example-random are visible).
Environment