Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upMake promtool better for CI with syntax-only config check #5222
Comments
glightfoot
referenced a pull request that will
close
this issue
Feb 14, 2019
Open
Add flag for syntax-only config file checking in promtool #5223
This comment has been minimized.
This comment has been minimized.
|
I do not agree with this. Those files are part of the configuration and I want promtool to check that it can actually read them. |
This comment has been minimized.
This comment has been minimized.
|
@roidelapluie - this will not change that behavior. I agree that that is an important check to have available. This will only add the ability to do the tests without those files as a new feature.
|
simonpasquier
added
the
component/promtool
label
Feb 21, 2019
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
Is there any way we can move this along? I had syntax bug get checked in that we could have prevented with this... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
glightfoot commentedFeb 14, 2019
Proposal
Use case. Why is this important?
We validate our rules with promtool in CI before deploying, it would be nice to be able to check for config file syntax validity without having to deploy all secrets, certs, etc.
Bug Report
What did you do?
promtool check config prometheus.yamlWhat did you expect to see?
What did you see instead? Under which circumstances?
Environment
CI (explicitly does not have the token and certs present in the deployment)
System information:
Linux 3.10.0-514.26.2.el7.x86_64 x86_64
Prometheus version:
2.7.1