Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport series selector for label/names and label/:name/values API #5248
Comments
jobrs
changed the title
Support series selector for label/:name/values
Support series selector for label/names and label/:name/values API
Feb 21, 2019
This comment has been minimized.
This comment has been minimized.
|
This discussion had come up during the implementation of |
codesome
referenced this issue
Feb 21, 2019
Closed
Support selectors for LabelNames and LabelValues #530
This comment has been minimized.
This comment has been minimized.
|
@codesome Agreed, see my last sentence. Still I would find the API addition useful, since future versions of the TSDB might (wishful thinking) allow for an optimised implementation and the addition would be consistent with the rest of the API. |
jobrs
referenced this issue
Feb 21, 2019
Open
Optimize label/names and label/:name/values implementation #35
This comment has been minimized.
This comment has been minimized.
|
Quoting prometheus/tsdb#530 (comment) from @brian-brazil
|
This comment has been minimized.
This comment has been minimized.
|
@jobrs is there anything else we need to add the the issue? |
This comment has been minimized.
This comment has been minimized.
|
@krasi-georgiev no, these are the points I wanted to raise |
This comment has been minimized.
This comment has been minimized.
|
In that case I hope you don't mind closing the issue and can revisit at a later point when we can have a better answer. |
This comment has been minimized.
This comment has been minimized.
|
closing this one, since the requested API addition is not needed from functional and performance perspective |
jobrs commentedFeb 21, 2019
•
edited by krasi-georgiev
Proposal
Add support for series selectors (i.e. match[]) to the
label/namesresp.label/:name/valuesAPIs, so that the list of label names and values can be constrained to a subset of series.This is useful to build
tenant=xyz.You could use the
/seriesAPI for that purpose but that's quite a complex operation (example). I am hoping that this could be implemented in a much more efficient way on a lower layer.