Skip to content

/prometheus

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Godeps clones all dependencies from the internet #525

Closed
juliusv opened this Issue Feb 13, 2015 · 2 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@juliusv
@juliusv
Copy link
Member

juliusv commented Feb 13, 2015

Relevant pstree snippet from running make build:

https://gist.githubusercontent.com/juliusv/1a91e10cda75cded9889/raw/fa8bdd40d33720c472ba65fd2ecfe6e1ed50ce2a/gistfile1.txt

This shouldn't clone any of the external dependencies from GitHub (or elsewhere), since they are vendored.

@juliusv juliusv added the bug label Feb 13, 2015

@juliusv

This comment has been minimized.

Sign in to view
Copy link
Member Author

juliusv commented Feb 13, 2015

cc @stuartnelson3

juliusv added a commit that referenced this issue Feb 13, 2015

@juliusv
Copy vendored deps manually instead of using Godeps. 
We were using Godep incorrectly (cloning repos from the internet during
build time instead of including Godeps/_workspace in the GOPATH via
"godep go"). However, to avoid even having to fetch "godeps" from the
internet during build, this now just copies the vendored files into the
GOPATH.

Also, the protocol buffer library moved from Google Code to GitHub,
which is reflected in these updates.

This fixes #525
Loading status checks…
ea2f797

@juliusv juliusv referenced this issue Feb 13, 2015

Merged

Copy vendored deps manually instead of using Godeps. #527

juliusv added a commit that referenced this issue Feb 17, 2015

@juliusv
Copy vendored deps manually instead of using Godeps. 
We were using Godep incorrectly (cloning repos from the internet during
build time instead of including Godeps/_workspace in the GOPATH via
"godep go"). However, to avoid even having to fetch "godeps" from the
internet during build, this now just copies the vendored files into the
GOPATH.

Also, the protocol buffer library moved from Google Code to GitHub,
which is reflected in these updates.

This fixes #525
af627bb

@juliusv juliusv closed this in #527 Feb 17, 2015

simonpasquier pushed a commit to simonpasquier/prometheus that referenced this issue Oct 12, 2017

@juliusv
Merge pull request prometheus#525 from prometheus/grobie/pr-template-… 
…for-output-repo

Add template to redirect people to docs repo for changes
5474f1b
@lock

This comment has been minimized.

Sign in to view
Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.