Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade github.com/miekg/dns #5263

Closed
sylr opened this Issue Feb 24, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@sylr
Copy link
Contributor

sylr commented Feb 24, 2019

Latest version of github.com/miekg/dns does not have the ErrTruncated anymore, see: miekg/dns#815

The commit message says:

Any program using ErrTruncated will fail to compile when they update to
this version: this is by design: you're doing it wrong. For checking if
a message was truncated you should checked the msg.Truncated boolean;
assuming the unpack didn't fail.

Thanos use a recent version of github.com/miekg/dns and it is not an issue now but it might become (for Thanos) if #5009 makes it to master as the dependency tree of prometheus within thanos will become bigger as Thanos imports github.com/prometheus/rules (indirectly I guess) which will import github.com/prometheus/config which itself imports a lot of libs needed for discovery like github.com/miekg/dns.

cc @bwplotka

@sylr sylr changed the title Upgrade miekg/dns Upgrade github.com/miekg/dns Feb 24, 2019

@simonpasquier

This comment has been minimized.

Copy link
Member

simonpasquier commented Feb 25, 2019

Closed by #5020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.