Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upUpgrade github.com/miekg/dns #5263
Comments
sylr
changed the title
Upgrade miekg/dns
Upgrade github.com/miekg/dns
Feb 24, 2019
This comment has been minimized.
This comment has been minimized.
|
Closed by #5020 |
simonpasquier
closed this
Feb 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
sylr commentedFeb 24, 2019
•
edited
Latest version of
github.com/miekg/dnsdoes not have the ErrTruncated anymore, see: miekg/dns#815The commit message says:
Thanos use a recent version of
github.com/miekg/dnsand it is not an issue now but it might become (for Thanos) if #5009 makes it to master as the dependency tree of prometheus within thanos will become bigger as Thanos importsgithub.com/prometheus/rules(indirectly I guess) which will importgithub.com/prometheus/configwhich itself imports a lot of libs needed for discovery likegithub.com/miekg/dns.cc @bwplotka