Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 3rd party service like dependabot to keep up with vendored libs #5265

Open
sylr opened this Issue Feb 24, 2019 · 4 comments

Comments

Projects
None yet
4 participants
@sylr
Copy link
Contributor

sylr commented Feb 24, 2019

I was wondering if prometheus could use a service like https://dependabot.com/ to help upgrade the vendored libs.

Dependabot is a github app which creates pull requests as soon as it detects that a lib used in the project has a new version released. It currently only updates the go.mod and go.sum files but does not update the vendor/ dir but I have made a script for another project which called by travis updates the PR with the changes in vendor/.

I know that Thanos is using this service. Maybe prometheus could do the same.

Thoughts ?

@beorn7

This comment has been minimized.

Copy link
Member

beorn7 commented Feb 25, 2019

Sounds to me like a good idea in general, especially with the expected wider adoption of go modules.

@simonpasquier you might have the most qualified opinion about this.

@simonpasquier

This comment has been minimized.

Copy link
Member

simonpasquier commented Feb 25, 2019

The idea is interesting. I had a quick look and tried to use it on my forks of prometheus and alertmanager but it complains that it can't parse the go.mod file. The level of authorization requested by dependabot is also quite high:
image

@sylr I guess that dependabot-travis.sh is the custom script you're mentioning in the original description?

@sylr

This comment has been minimized.

Copy link
Contributor Author

sylr commented Feb 25, 2019

@simonpasquier Yes it is.

@hmarr

This comment has been minimized.

Copy link

hmarr commented Feb 26, 2019

I'm one of the folks building Dependabot. We'd love to help out in any way we can, so please feel free to ping me if you have any questions 🙂

The go.mod issue is now fixed. Thanks @simonpasquier for raising it.

We also plan to add vendoring support in due course. In the meantime, a CI script or GitHub Actions (if you have access) is a good solution - several of our users are doing something similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.