retention shown in runtime page set to 0s

[roidelapluie]

In Prometheus 2.8-rc0 the runtime page shows '0s' retention.

2.7.1:

2.8-rc0:

Bisect:
a3c41f4 is the first bad commit
commit a3c41f4
Author: Krasi Georgiev krasi-georgiev@users.noreply.github.com
Date: Tue Feb 19 13:53:43 2019 +0200

use the default time retention value only when no size retention is set (#5216)

fixes https://github.com/prometheus/prometheus/issues/5213

Now that we have time and size base retention time bases should not have a default value. A default is set only when both - time and size flags are not set.

This change will not affect current installations that rely on the default time based value, and will avoid confusions when only the size retention is set and it is expected that the default time based setting would be no longer in place.

Signed-off-by: Krasi Georgiev <kgeorgie@redhat.com>

:040000 040000 e9acc051e5fd1bfc7262fbd60e675f59976ffa3e 35e8966e63113b7bfc3a61432bbdab27d5a006f6 M cmd

[roidelapluie]

Not sure if that is a bug or not but it is definitively confusing. Maybe we should add to the "Runtime" page the actual retention values.

[roidelapluie]

cc @krasi-georgiev

[krasi-georgiev]

what flags did you use when starting Prometheus?

[krasi-georgiev]

just replicated it, the retention is set to 15d as before,but the GUI shows incorrect info. Will fix soon. Thanks.

[roidelapluie]

Since now the flag is optional, I think maybe we could have in runtime page: "TSDB retention: 15d"

[roidelapluie]

The values printed out could be:

• 15d
• 15d or 12 GB
• 12GB

[krasi-georgiev]

I opened a PR with the fix.

Since now the flag is optional, I think maybe we could have in runtime page: "TSDB retention: 15d"

not sure what you mean by this comment.

[roidelapluie]

Oh nevermind I had a more complex fix in mind