Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRequired Go version in README is wrong #5455
Comments
simonpasquier
added
component/documentation
help wanted
labels
Apr 15, 2019
This comment has been minimized.
This comment has been minimized.
|
Do you want to submit the PR for this? |
This was referenced Apr 16, 2019
Closed
This comment has been minimized.
This comment has been minimized.
|
fixed in #5471 |
brian-brazil
closed this
Apr 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
aa2811 commentedApr 12, 2019
•
edited
Bug Report
What did you do?
Tried to
go_getpromtool in the golang:1.11.5 container. According to the README, go 1.11+ should be sufficient to do this.What did you expect to see?
Sucessful docker build
What did you see instead? Under which circumstances?
Environment
golang:1.11.5 container.
This step worked in golang:1.12.3, and judging by this file which has recently been added, I think this is because you now need go 1.12+ to build from source, so the README needs updating.