Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required Go version in README is wrong #5455

Closed
aa2811 opened this Issue Apr 12, 2019 · 2 comments

Comments

Projects
None yet
4 participants
@aa2811
Copy link

aa2811 commented Apr 12, 2019

Bug Report

What did you do?

Tried to go_get promtool in the golang:1.11.5 container. According to the README, go 1.11+ should be sufficient to do this.

What did you expect to see?
Sucessful docker build

What did you see instead? Under which circumstances?

Step 2/14 : RUN GOOS=linux GOARCH=amd64 CGO_ENABLED=0 go get -u github.com/prometheus/prometheus/cmd/promtool
 ---> Running in ebf3f42eb56d
# github.com/prometheus/prometheus/vendor/github.com/prometheus/tsdb/goversion
src/github.com/prometheus/prometheus/vendor/github.com/prometheus/tsdb/goversion/init.go:17:9: undefined: _SoftwareRequiresGOVERSION1_12
The command '/bin/sh -c GOOS=linux GOARCH=amd64 CGO_ENABLED=0 go get -u github.com/prometheus/prometheus/cmd/promtool' returned a non-zero code: 2

Environment

golang:1.11.5 container.

This step worked in golang:1.12.3, and judging by this file which has recently been added, I think this is because you now need go 1.12+ to build from source, so the README needs updating.

@simonpasquier

This comment has been minimized.

Copy link
Member

simonpasquier commented Apr 15, 2019

Do you want to submit the PR for this?

This was referenced Apr 16, 2019

@cstyan

This comment has been minimized.

Copy link
Contributor

cstyan commented Apr 17, 2019

fixed in #5471

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.