Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AND operator precedence is too high #555

Closed
aecolley opened this Issue Feb 24, 2015 · 5 comments

Comments

Projects
None yet
3 participants
@aecolley
Copy link

aecolley commented Feb 24, 2015

The expression:
time() - start_time{job="x"} > 86400
    and
start_time{job="x"} > end_time{job="x"}

should be parsed as:
(time() - start_time{job="x"} > 86400)
    and
(start_time{job="x"} > end_time{job="x"})

but it is actually parsed as:
((time() - start_time{job="x"} > 86400)
    and
start_time{job="x"}) > end_time{job="x"}

rules/lexer.l classifies AND and OR as CMP_OP just like == and >. They should be a different level of operation.

@juliusv

This comment has been minimized.

Copy link
Member

juliusv commented Mar 1, 2015

Thanks for reporting! I agree, this should be changed.

@atombender

This comment has been minimized.

Copy link
Contributor

atombender commented Apr 23, 2015

+1. This bit me today. At the very least the current precedence should be documented.

@juliusv

This comment has been minimized.

Copy link
Member

juliusv commented Apr 23, 2015

This will be fixed along with the parser / query engine refactoring that is likely to be done in the next couple of weeks.

@juliusv

This comment has been minimized.

Copy link
Member

juliusv commented May 7, 2015

Just merged the new query engine + parser feature branch into master: #676

This should be fixed now.

@juliusv juliusv closed this May 7, 2015

simonpasquier pushed a commit to simonpasquier/prometheus that referenced this issue Oct 12, 2017

Merge pull request prometheus#555 from prometheus/grobie/standardize-…
…on-seconds

Remove examples of time metrics not using seconds
@lock

This comment has been minimized.

Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.