Alert templates type conflict: SampleValue v. float64

[aecolley]

Attempts to interpolate {{humanizeDuration $value}} fail with a type error:

wrong type for value; expected float64; got model.SampleValue

There's no way to work around this.

[brian-brazil]

Hmm, try {{value $value | humanizeDuration}}

Sounds like a bug.

[brian-brazil]

Ah, it's a casting problem. We need to cast to float64 in

prometheus/rules/manager/manager.go

Line 182 in 5f27629

Value clientmodel.SampleValue

[juliusv]

One thing to watch out for when changing this: we currently have a nice String() method for serializing clientmodel.SampleValue:

https://github.com/prometheus/client_golang/blob/master/model/samplevalue.go#L35-L37

If we cast everything to float64, then the default string representation will look less nice for many use cases. For example, timestamps will by default be printed in scientific notation (1.413989023e+09) and shenanigans like that.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.