Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign up0/0 evaluates to +Inf but should be NaN #597
Comments
This comment has been minimized.
This comment has been minimized.
|
Ah, thanks for pointing this out! Will fix this. Sorry in case this paged you at night :) |
juliusv
added a commit
that referenced
this issue
Mar 16, 2015
juliusv
referenced this issue
Mar 16, 2015
Merged
Fix special value handling in division and modulo. #598
This comment has been minimized.
This comment has been minimized.
|
Fix out in #598 |
juliusv
closed this
in
#598
Mar 16, 2015
simonpasquier
pushed a commit
to simonpasquier/prometheus
that referenced
this issue
Oct 12, 2017
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 24, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
locked and limited conversation to collaborators
Mar 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
aecolley commentedMar 16, 2015
This is inconsistent with float arithmetic in Go. It's not a theoretical-only concern either: I had an alert spuriously fire because the (summary-based) average was too high. You see, sum and count were both zero, so the mean ratio was +Inf which was larger than the threshold; NaN would not have alerted in that case.
Workaround: AND your alert rules with tests like foo_count != 0.