Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building from .zip should be possible #609

Closed
quinox opened this Issue Mar 21, 2015 · 3 comments

Comments

Projects
None yet
3 participants
@quinox
Copy link
Contributor

quinox commented Mar 21, 2015

Currently you cannot build Prometheus using the zip-files mentioned in fe. https://github.com/prometheus/prometheus/releases/tag/0.12.0.

When you try you get a bunch of warnings such as fatal: Not a git repository (or any parent up to mount point /tmp) eventually followed by the usage output of 6l and the failure Makefile:30: recipe for target 'build' failed.

Relevant chat on IRC:

jrv | ah, the zip file doesn't work because the Makefile expects the source directory to still be a git repository.
jrv | GitHub creates those zip files automatically, so we never tried that.
jrv | "-X main.buildRevision" isn't followed by an argument for that reason, which is why ld6 crashes
jrv | cause that's built via a git command
jrv | VERSION=$(shell cat git rev-parse --show-toplevel/VERSION)

@abraithwaite

This comment has been minimized.

Copy link
Contributor

abraithwaite commented May 20, 2015

Is there any reason this version can't be in the Makefile?

It'd be nice to build it from an archive which have predictable stable urls.

@matthiasr

This comment has been minimized.

Copy link
Contributor

matthiasr commented May 20, 2015

Reopening, as discussed in #707 this is not really fixed yet.

As a workaround, set the VERSION variable either as VERSION=something make or make VERSION=something. After #707, both do the same.

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.