Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement ValueStream? #638
Comments
This comment has been minimized.
This comment has been minimized.
|
I've been playing around with multi-tier aggregation by exposing handcrafted "metrics" endpoints as console templates, building on this example. You can, instead of matching the name, specify any query (but need to then give it a new name). The effect is that one Prometheus can publish arbitrary (raw, aggregated or otherwise computed) timeseries that are then available to be scraped (albeit not at the standard endpoint) by any other prometheus. |
This comment has been minimized.
This comment has been minimized.
|
@sunyc Could you explain what you mean by "valuestream"? |
This comment has been minimized.
This comment has been minimized.
|
@matthiasr which is obviously not very efficient... And there is timestamping issue. @beorn7 ValueStream is a RPC service that allows an prometheus instance scrape timeseries from another prometheus . Which also retains original timestamp etc. It has a number of usefulness, namely, one could have a prometheus that valuestream from several peers for aggregation etc etc etc. |
This comment has been minimized.
This comment has been minimized.
|
I'm not too worried about timestamps … when aggregating for example request counts from many individual instances as one timeseries, there is no one timestamp anyway. And if the samples are just passed through 1:1 then why aggregate in the first place? |
This comment has been minimized.
This comment has been minimized.
|
The Prometheus scrape protocol already contains a timestamp for that purpose. However, it is currently not possible to scrape multiple samples for one time series in one scrape. |
This comment has been minimized.
This comment has been minimized.
|
@matthiasr because scrape is not synchronized between targets, If there were no timestamp in the output the aggregation would produce wrong values.. |
This comment has been minimized.
This comment has been minimized.
|
Heya Yucong, valuestreaming aka hierarchical federation is on our roadmap: Right now we only have the "hack" that Matthias mentioned, but soon[tm] Cheers, On Wed, Apr 15, 2015 at 5:27 PM, Yucong Sun notifications@github.com
|
This comment has been minimized.
This comment has been minimized.
|
I would be happy to help (maybe we can also use go-grpc now), believe it or not, i spent quite a bit of of time on it in the past life . LoL |
This comment has been minimized.
This comment has been minimized.
|
I'll close this as a duplicate of #9 (updated that issue with the notion of "streaming"). |
beorn7
closed this
Apr 15, 2015
This comment has been minimized.
This comment has been minimized.
|
@sunyc That'd be great in general. As a smaller starter project it'd probably be good to start with something small to get acquainted with the whole code and contributing business, and then go from there. We're all also hanging out on |
simonpasquier
pushed a commit
to simonpasquier/prometheus
that referenced
this issue
Oct 12, 2017
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 24, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
thefallentree commentedApr 15, 2015
Hi,
I'm surprised to see that prometheus (or should I say, borgmon2) doesn't implement a valuestream function yet (allow transferring timeseries between prometheus instances). Which I thought was crucial to implement a multi-tier aggregation hierarchy,
Any thoughts?
BTW: you guys are awsome creating prometheus!