Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle resource files (HTML, CSS/JS, images, templates) into binary #68

Closed
juliusv opened this Issue Feb 8, 2013 · 5 comments

Comments

Projects
None yet
3 participants
@juliusv
Copy link
Member

juliusv commented Feb 8, 2013

It would be great if we could distribute and run Prometheus as a single binary without any external files needed for serving e.g. the web interface.

One possibility how to do this: https://github.com/jteeuwen/go-bindata
Another option: https://github.com/bradfitz/camlistore/blob/master/pkg/fileembed/fileembed.go

@ghost ghost assigned juliusv Feb 8, 2013

@ghost ghost assigned discordianfish Mar 18, 2013

@discordianfish

This comment has been minimized.

@juliusv

This comment has been minimized.

Copy link
Member Author

juliusv commented Mar 18, 2013

Nice, thank you!

Only one remark: if we don't strictly need the "foo.html" => "fooHtml"
conversion, I would vote for just using the original filename as the map
key. Less code, less error possibilities, easier to read.

Julius

On Mon, Mar 18, 2013 at 6:01 PM, discordianfish notifications@github.comwrote:

WIP, see
https://github.com/prometheus/prometheus/tree/feature/build-in-static-assets


Reply to this email directly or view it on GitHubhttps://github.com//issues/68#issuecomment-15067034
.

@matttproud

This comment has been minimized.

Copy link
Member

matttproud commented Mar 18, 2013

Seconded.

2013/3/18 juliusv notifications@github.com

Nice, thank you!

Only one remark: if we don't strictly need the "foo.html" => "fooHtml"
conversion, I would vote for just using the original filename as the map
key. Less code, less error possibilities, easier to read.

Julius

On Mon, Mar 18, 2013 at 6:01 PM, discordianfish notifications@github.comwrote:

WIP, see

https://github.com/prometheus/prometheus/tree/feature/build-in-static-assets


Reply to this email directly or view it on GitHub<
https://github.com/prometheus/prometheus/issues/68#issuecomment-15067034>
.


Reply to this email directly or view it on GitHubhttps://github.com//issues/68#issuecomment-15074006
.

@matttproud

This comment has been minimized.

Copy link
Member

matttproud commented Mar 27, 2013

Done! Thank you, @discordianfish!

@matttproud matttproud closed this Mar 27, 2013

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 25, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 25, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.