Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upallow to override the default PrometheusURL in alerts #716
Comments
This comment has been minimized.
This comment has been minimized.
|
I think this is a good idea. |
This comment has been minimized.
This comment has been minimized.
|
@brian-brazil should I provide a PR? |
This comment has been minimized.
This comment has been minimized.
|
If you can that'd be great. |
This comment has been minimized.
This comment has been minimized.
|
@gesellix Add it as a flag to https://github.com/prometheus/prometheus/blob/master/web/web.go |
This comment has been minimized.
This comment has been minimized.
|
@juliusv proposed flag name: |
This comment has been minimized.
This comment has been minimized.
|
@gesellix Sounds good. |
gesellix
referenced this issue
May 22, 2015
Merged
allow to override the default os.Hostname() when creating PrometheusURLs #717
This comment has been minimized.
This comment has been minimized.
|
resolved with #717 |
gesellix
closed this
May 23, 2015
simonpasquier
pushed a commit
to simonpasquier/prometheus
that referenced
this issue
Oct 12, 2017
This comment has been minimized.
This comment has been minimized.
lock
bot
commented
Mar 24, 2019
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
lock
bot
locked and limited conversation to collaborators
Mar 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
gesellix commentedMay 22, 2015
When running Prometheus in a Docker container and producing alerts, they contain a GeneratorURL looking like this:
http://b640ba8f91c1:9090//graph#.... Theb640ba8f91c1hash is a generated Docker container hostname. Obviously, such hostnames are useless in the actual alerts (or in the Alertmanager/alertsoverview).Would it make sense to add a configuration option setting the desired external hostname? When empty, the current mechanism could be used.