Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerts HTML #735

Closed
camerondavison opened this Issue May 26, 2015 · 6 comments

Comments

Projects
None yet
3 participants
@camerondavison
Copy link

camerondavison commented May 26, 2015

templates/alerts.html looks to be missing the path prefix. The links on the alerts to the graph page do not have the path prefix

@juliusv

This comment has been minimized.

Copy link
Member

juliusv commented May 26, 2015

@a86c6f7964 Thanks yet again!

@quinox wanna give this a shot? Otherwise I can handle it.

@quinox

This comment has been minimized.

Copy link
Contributor

quinox commented May 26, 2015

In this case I'll let you handle it

@juliusv

This comment has been minimized.

Copy link
Member

juliusv commented May 28, 2015

@a86c6f7964 Could you clarify where exactly a path prefix is missing? If I configure an alert and head to /pathprefix/alerts, all the links on there (like alerting expressions linking to their graph version) have the right path prefix.

Which version are you using? And if you're building from source, try doing make clean && make one more time.

@camerondavison

This comment has been minimized.

Copy link
Author

camerondavison commented May 28, 2015

branch  stable
date    20150522-15:12:08
go_version  1.4.2
revision    43b41c5
user    root
version 0.13.3

Ah... I missed 3e914a8 looks like once I move to .14 then it will be good. Sorry about that. I could have sworn I tried to see if things were fixed in master.

@juliusv

This comment has been minimized.

Copy link
Member

juliusv commented May 28, 2015

@a86c6f7964 Ah cool, thanks for confirming!

@lock

This comment has been minimized.

Copy link

lock bot commented Mar 24, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked and limited conversation to collaborators Mar 24, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.